Convert GVFS.Hooks to C++ #1426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilbaker
commented
Aug 7, 2019
| @@ -0,0 +1,18 @@ | |||
| #pragma once | |||
|
|
|||
| inline std::vector<std::string> String_Split(char deliminator, const std::string toSplit) | |||
There was a problem hiding this comment.
const std::string toSplit -> const std::string& toSplit
wilbaker
commented
Aug 7, 2019
|
|
||
| bool FileSystem_FileExists(const PATH_STRING& path) | ||
| { | ||
| DWORD attributes = GetFileAttributesW(path.c_str()); |
There was a problem hiding this comment.
Add comment referencing https://devblogs.microsoft.com/oldnewthing/20071023-00/?p=24713
wilbaker
commented
Aug 7, 2019
| } | ||
| } | ||
|
|
||
| int main(int argc, char *argv[]) |
There was a problem hiding this comment.
Move all function implementations above main to a better spot
wilbaker
commented
Aug 7, 2019
| } | ||
|
|
||
| std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> utf16conv; | ||
| std::wstring command = utf16conv.from_bytes(processName) + L" " + utf16conv.from_bytes(args); |
wilbaker
commented
Aug 7, 2019
| #include "common.h" | ||
| #include "FileSystem.h" | ||
|
|
||
| PATH_STRING Upgrader_GetHighestAvailableVersionFilePath(); |
There was a problem hiding this comment.
Rename file to Upgrader.h
wilbaker
commented
Aug 7, 2019
| @@ -31,9 +31,13 @@ enum ReturnCode | |||
| PipeReadFailed = 8, | |||
| FailureToDownload = 9, | |||
| PathNameError = 10, | |||
| InvalidCommand = 11, | |||
| InvalidResponse = 12, | |||
There was a problem hiding this comment.
Fix spacing (here and below)
|
Closing this PR for now, will re-open when this work has higher priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Still a work in progress - this was something I hacked out that still needs cleanup
Resolves #716
Convert GVFS.Hooks from C# to C++
TODO:
Follow up work (separate PRs):
*.Shared.csfiles that existed only to be shared with GVFS.Hooks